Skip to content

CI badge #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2024
Merged

CI badge #93

merged 3 commits into from
Aug 20, 2024

Conversation

Tieqiong
Copy link
Contributor

No description provided.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid deviating from norms we probably shouldn't change the name of this. Or if it is really bad, change it everywhere, not just in diffpy.structure.

@Tieqiong
Copy link
Contributor Author

@sbillinge By changing this name the only difference would be the appearance of the badge, like whether it shows |Test|pass> or |Validate using pytest|pass>. Otherwise changing the name wouldn't actually change anything. But I agree we should have a norm for the names

@sbillinge sbillinge merged commit 9dc84df into diffpy:main Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants