Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF diffraction object #47

Open
sbillinge opened this issue Feb 12, 2024 · 3 comments
Open

PDF diffraction object #47

sbillinge opened this issue Feb 12, 2024 · 3 comments
Milestone

Comments

@sbillinge
Copy link
Contributor

sbillinge commented Feb 12, 2024

add PDF as a diffraction object

in principle we could have the PDF as part of the existing DiffractionObjects (so an object.on_r). Alternatively, we could define a new class called PdfObject that carries around the PDF. It would be good to have some discussion about the pro's and con's of these two possibilities before implementing.

@sbillinge sbillinge added this to the 3.5.1 release milestone Nov 15, 2024
@sbillinge
Copy link
Contributor Author

If we make a new object we may want to make a base-class that does as much work as possible and have PdfObject and DiffractionObject inherit the base-class

@bobleesj
Copy link
Contributor

Discussion from #221 (comment)

@sbillinge would find wsinterp embedded in PDFObject highly useful. Probably we can make separate issues later once we are tackling PDFObject?

@sbillinge
Copy link
Contributor Author

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants