Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wsinterp docstrings and test function #221

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

bobleesj
Copy link
Contributor

No description provided.

Copy link

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (5f67f6c) to head (f737a13).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files           8        8           
  Lines         325      325           
=======================================
  Hits          324      324           
  Misses          1        1           
Files with missing lines Coverage Δ
tests/test_resample.py 94.73% <100.00%> (ø)

Copy link
Contributor Author

@bobleesj bobleesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review - pls see my in-line comments.

@bobleesj bobleesj marked this pull request as ready for review December 13, 2024 04:33
@bobleesj bobleesj changed the title Improve wsinterp docstring and test function Improve wsinterp docstrings and test function Dec 13, 2024
@bobleesj bobleesj mentioned this pull request Dec 13, 2024
59 tasks
Copy link
Contributor Author

@bobleesj bobleesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbillinge ready for review! - added DOI, didn't add any additional empty liens

@bobleesj
Copy link
Contributor Author

@sbillinge ready for review! - added DOI, didn't add any additional empty liens

Screenshot 2024-12-13 at 10 29 53 AM

@sbillinge it passes - just codecov..

@sbillinge
Copy link
Contributor

This looks great, o can merge when it passes.

Nor I am greedy though..... Would it be nice if it could take, optionally, a DiffractionObject and return a distraction object? Or maybe it is better to make a method on the DO itself?

@bobleesj
Copy link
Contributor Author

bobleesj commented Dec 13, 2024

Screenshot 2024-12-13 at 10 31 06 AM

@sbillinge v5 has been released. Shall we migrate from our current v4 to v5 for Codecov actions?

https://github.com/codecov/codecov-action

@bobleesj
Copy link
Contributor Author

Nor I am greedy though..... Would it be nice if it could take, optionally, a DiffractionObject and return a distraction object? Or maybe it is better to make a method on the DO itself?

having wsinterp as a modular and standalone function, and then have DiffractionObject integrate wsinterp seems like a scalable approach to me imo?

@sbillinge
Copy link
Contributor

Nor I am greedy though..... Would it be nice if it could take, optionally, a DiffractionObject and return a distraction object? Or maybe it is better to make a method on the DO itself?

having wsinterp as a modular and standalone function, and then have DiffractionObject integrate wsinterp seems like a scalable approach to me imo?

Yah my thinking too. Actually it is for pdfs, not for diffraction, but for sure there is a PDFObject in our future.

@bobleesj
Copy link
Contributor Author

Yah my thinking too. Actually it is for pdfs, not for diffraction, but for sure there is a PDFObject in our future.

I left a comment in the PDF object issue here: #47

Maybe we could merge this, once Billingegroup/release-scripts#109 is merged all the way to v0.

@sbillinge sbillinge merged commit 8fe6b99 into diffpy:main Dec 13, 2024
2 of 3 checks passed
@bobleesj bobleesj deleted the cleanup branch December 13, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants