-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve wsinterp
docstrings and test function
#221
Conversation
Warning! No news item is found for this PR. If this is a user-facing change/feature/fix, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 8 8
Lines 325 325
=======================================
Hits 324 324
Misses 1 1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for review - pls see my in-line comments.
wsinterp
docstring and test functionwsinterp
docstrings and test function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbillinge ready for review! - added DOI, didn't add any additional empty liens
![]() @sbillinge it passes - just codecov.. |
This looks great, o can merge when it passes. Nor I am greedy though..... Would it be nice if it could take, optionally, a DiffractionObject and return a distraction object? Or maybe it is better to make a method on the DO itself? |
![]() @sbillinge |
having |
Yah my thinking too. Actually it is for pdfs, not for diffraction, but for sure there is a PDFObject in our future. |
I left a comment in the PDF object issue here: #47 Maybe we could merge this, once Billingegroup/release-scripts#109 is merged all the way to |
No description provided.