Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename input_scattering_quantity to input_data in DiffractionObject init #215

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

bobleesj
Copy link
Contributor

Closes #212

Since we are doing a big API migration, didn't add deprecation warnings if that's okay.

@bobleesj bobleesj marked this pull request as ready for review December 12, 2024 17:50
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (fce1a32) to head (f311988).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files           8        8           
  Lines         325      325           
=======================================
  Hits          324      324           
  Misses          1        1           
Files with missing lines Coverage Δ
tests/test_diffraction_objects.py 100.00% <ø> (ø)

@bobleesj
Copy link
Contributor Author

@sbillinge ready for review

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, no need to deprecate. Everything is broken in DOs.

I think we need to update docs too. Did you do a global search/replace in PyCharm?

@bobleesj
Copy link
Contributor Author

bobleesj commented Dec 12, 2024

Screenshot 2024-12-12 at 12 56 48 PM

@sbillinge made a rookie mistake. Fixed all in the latest commit. Ready for review

The only part left is the content from CHANGELOG.rst from 3.4.0, which should be left out as it is.

@sbillinge sbillinge merged commit 5f67f6c into diffpy:main Dec 12, 2024
5 checks passed
@bobleesj bobleesj deleted the mv-input-scattering-quan branch December 12, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename input_scattering_quantity to input_data in DiffractionObject
2 participants