Skip to content

Refactor test-on-xtype test function #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

bobleesj
Copy link
Contributor

Closes #229 - Refactor test_on_xtype() using @pytest.mark.parametrize and conftest.py

@bobleesj bobleesj marked this pull request as ready for review December 14, 2024 19:31
Copy link

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

@bobleesj
Copy link
Contributor Author

@sbillinge Ready for review - probably better to review this #228 first..

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (75e0ef8) to head (8053d31).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #231   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          357       362    +5     
=========================================
+ Hits           357       362    +5     
Files with missing lines Coverage Δ
tests/conftest.py 100.00% <100.00%> (ø)
tests/test_diffraction_objects.py 100.00% <100.00%> (ø)

@sbillinge sbillinge merged commit 3918433 into diffpy:main Dec 14, 2024
4 of 5 checks passed
@bobleesj bobleesj deleted the refactor-test-on-xtype branch December 14, 2024 19:56
@bobleesj bobleesj mentioned this pull request Dec 19, 2024
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor test_on_xtype() using @pytest.mark.parametrize and conftest.py
2 participants