Add Bytes opaque type to the engine and damlc #20754
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… introduce opaque types to model byte strings
carlpulley-da
commented
Feb 10, 2025
| // Copyright (c) 2025 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package com.daml.ledger.javaapi.data; |
There was a problem hiding this comment.
TODO: make similar change to canton
carlpulley-da
commented
Feb 10, 2025
| @@ -84,6 +84,7 @@ object LfEngineToApi { | |||
| case Lf.ValueContractId(c) => Right(api.Value(api.Value.Sum.ContractId(c.coid))) | |||
| case Lf.ValueBool(b) => Right(api.Value(api.Value.Sum.Bool(b))) | |||
| case Lf.ValueDate(d) => Right(api.Value(api.Value.Sum.Date(d.days))) | |||
| case Lf.ValueBytes(bytes) => Right(api.Value(api.Value.Sum.Bytes(bytes.toByteString))) | |||
There was a problem hiding this comment.
TODO: make similar change to canton
carlpulley-da
commented
Feb 10, 2025
| @@ -81,6 +81,7 @@ abstract class ValueValidator { | |||
| .map(Lf.ValueDate.apply) | |||
| case Sum.Text(text) => Right(Lf.ValueText(text)) | |||
| case Sum.Int64(value) => Right(Lf.ValueInt64(value)) | |||
| case Sum.Bytes(bytes) => Right(Lf.ValueBytes(Bytes.fromByteString(bytes))) | |||
There was a problem hiding this comment.
TODO: make similar change to canton
carlpulley-da
commented
Feb 10, 2025
| @@ -363,6 +364,12 @@ object SValue { | |||
| Either.cond(test = s.abs <= MaxScale, right = s.toInt, left = "invalide scale") | |||
There was a problem hiding this comment.
TODO: invalide -> invalid?
carlpulley-da
commented
Feb 10, 2025
| @@ -28,6 +28,7 @@ da_scala_library( | |||
| "//daml-lf/api-type-signature", | |||
| "//daml-lf/data", | |||
| "//daml-lf/transaction", | |||
| "@maven//:com_google_protobuf_protobuf_java", | |||
There was a problem hiding this comment.
Added so that the lf-value-json may access the protobuf ByteString data structure
carlpulley-da
changed the title
carlpulley-da
commented
Feb 10, 2025
| @@ -32,6 +32,7 @@ da_scala_library( | |||
| "//daml-lf/data", | |||
| "//daml-lf/transaction", | |||
| "//ledger-service/lf-value-json", | |||
| "@maven//:com_google_protobuf_protobuf_java", | |||
There was a problem hiding this comment.
Added so that the ledger codegen may access the protobuf ByteString data structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Bytesdata types