Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1644: Add validation to importAcceptingStores mutation in the backend #1928

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

seluianova
Copy link
Contributor

@seluianova seluianova commented Feb 19, 2025

Short Description

Currently we have csv validation on the administration side, but no validation on the backend.
This means that if the request is sent directly to the backend, our validation rules can be violated.

Proposed Changes

  • remove import pipeline for nuernberg
  • add validation that the mandatory fields are not empty (name, street, houseNumber, postalCode, location)
  • return an error, if request contains duplicates (consider records as duplicate if the name, street, house number, zip code, and location are the same)
  • add data cleaning (remove trailing whitespaces)

Not included:
Check that the categoryId refers to the current project.
I think it would be better to do it after #1915

Side Effects

no?

Testing

tbd

Resolved Issues

Fixes: #1644

@seluianova seluianova linked an issue Feb 19, 2025 that may be closed by this pull request
@seluianova seluianova marked this pull request as draft February 19, 2025 16:10
@seluianova seluianova force-pushed the 1591-remove-import-pipeline-nuernberg branch from 6c36af3 to 981cba5 Compare February 19, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation to importAcceptingStores mutation in the backend Remove import pipeline nuernberg
1 participant