Support Spaces Key API

[lee-aaron]

Adds support for Spaces Key API based on digitalocean/openapi#958

[andrewsomething]

Doing some testing, I realized that that this was retrying a 403 Forbidden repeatedly. You'll probably want to inspect this error before returning a RetryableError.

By default, the godo client is configured to retry 500-level errors. So retry.RetryContext is generally only needed if there are specific cases you are trying to work around.

For example:

terraform-provider-digitalocean/digitalocean/project/resource_project.go

Lines 287 to 297 in 8473e52

	// Moving resources is async and projects can not be deleted till empty. Retries may be required.
	err := retry.RetryContext(ctx, d.Timeout(schema.TimeoutDelete), func() *retry.RetryError {
	_, err := client.Projects.Delete(context.Background(), projectID)
	if err != nil {
	if util.IsDigitalOceanError(err, http.StatusPreconditionFailed, "cannot delete a project with resources") {
	log.Printf("[DEBUG] Received %s, retrying project deletion", err.Error())
	return retry.RetryableError(err)
	}
	return retry.NonRetryableError(err)
	}

[lee-aaron]

I put in a few places where retries shouldn't happen

[danaelhe]

What scenario are you thinking that we'd need to retry a create request for? For example, sometimes we have to retry a request if we know we have to wait for another resource to be in a ready state (waiting on new database to accept connections, or a new droplet to be accessible etc.) or if we want a resource to be a in a certain state before we can use it.

[amahajan-do]

None of the bucket keys related scenarios are async in that sense. We don't have to wait for anything to be in a specific state.

[danaelhe]

Ok sweet, we're good to remove it then.

[amahajan-do]

Suggested change

	err := retry.RetryContext(ctx, 5*time.Minute, func() *retry.RetryError {
	log.Printf("[DEBUG] Deleting Spaces key: %s", d.Id())
	_, err := client.SpacesKeys.Delete(ctx, d.Id())
	if err != nil {
	if util.IsDigitalOceanError(err, http.StatusInternalServerError, "") || util.IsDigitalOceanError(err, http.StatusPreconditionFailed, "") {
	return retry.NonRetryableError(err)
	}
	return retry.RetryableError(
	fmt.Errorf("[WARN] Error deleting Spaces key: %s, retrying: %s", d.Id(), err))
	}
	return nil
	})
	if err != nil {
	return diag.Errorf("Error deleting Spaces key: %s", err)
	}
	log.Printf("[DEBUG] Deleting Spaces key: %s", d.Id())
	_, err := client.SpacesKeys.Delete(ctx, d.Id())
	if err != nil {
	return diag.Errorf("Error deleting Spaces key: %s", err)
	}