Superuser page for all opportunities. #450
Conversation
| @@ -16,21 +16,67 @@ | |||
| </li> | |||
| {% endif %} | |||
|
|
|||
| {% for page_number in page_obj.paginator.page_range %} | |||
There was a problem hiding this comment.
I had to make this change because the previous pagination template displayed all the page numbers, and as the number of pages increased, it started overflowing.
hemant10yadav
changed the title
| href="{% url 'opportunity:detail' org_slug=request.org.slug pk=opportunity.id %}"> | ||
| <span class="bi bi-eye"></span><span class="d-none d-md-inline"> View</span> | ||
| </a> | ||
| {% if request.org_membership.is_viewer %} |
There was a problem hiding this comment.
The "Edit" and "Add Budget" buttons can be removed from this view.
| @@ -1222,3 +1228,50 @@ def invoice_approve(request, org_slug, pk): | |||
| ) | |||
| payment.save() | |||
| return HttpResponse(headers={"HX-Trigger": "newInvoice"}) | |||
|
|
|||
|
|
|||
| class AllOpportunitiesView(SuperUserMixin, ListView): | |||
There was a problem hiding this comment.
We can build the list using the django-tables and django-filter libraries. It would make it easier to create a Table of Opportunities with filters.
There was a problem hiding this comment.
Yeah, this could be written with much less code (most of the HTML for filters and the table will be autogenerated, so you don't have to write it) if you go down that route. I have just made a PR that makes it more easier which you can base on.
Take a look at DeliveryStatsReport which is implemented in this way.
There was a problem hiding this comment.
I’m not sure if we can create the exact same view using django-tables, as we have used custom sortable links in opportunity list page. However, the ticket clearly mentions that it should look the same as the normal Opportunity page. I’m open to discussing this further.
There was a problem hiding this comment.
Django Tables has Meta options to enable sorting and ordering by columns. https://django-tables2.readthedocs.io/en/latest/pages/api-reference.html#Table.Meta
| @@ -122,6 +123,11 @@ def test_func(self): | |||
| ) or self.request.user.is_superuser | |||
|
|
|||
|
|
|||
| class SuperUserMixin(LoginRequiredMixin, UserPassesTestMixin): | |||
There was a problem hiding this comment.
There is already SuperUserRequiredMixin
There was a problem hiding this comment.
Thanks I will remove it and use the existing SuperUserRequiredMixin.
|
Is it not possible to use the existing view |
I am happy to use the same page, but doing so will make it much more complex, right? It is already being used for two cases: Opportunity and Managed Opportunity. |
CCCT-569