implement user visits dashboard #463
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| {% load crispy_forms_tags %} | ||
| {% block javascript %} | ||
| {{ block.super }} | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/echarts/5.4.3/echarts.min.js"></script> |
Check warning
Code scanning / CodeQL
Inclusion of functionality from an untrusted source Medium
| {% load crispy_forms_tags %} | ||
| {% block javascript %} | ||
| {{ block.super }} | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/echarts/5.4.3/echarts.min.js"></script> |
There was a problem hiding this comment.
Shouldn't this be added as a local dependency?
I'm also interested to know how you chose this library vs the others out there.
There was a problem hiding this comment.
One of the main requirements for this dashboard is to be able to customize the appearance to a high degree (focused on external demos), which this library is capable of. It has theme builder using which its possible to change a lot of styling. It's also used by Superset and so there's lot of parity in terms of being able to create whatever charts that are possible to build on superset (which the project team uses to build various charts/dashboards currently for internal use)
Shouldn't this be added as a local dependency?
Yes, I will modify.
|
@calellowitz Can I get review on this please? |
Product Description
This implements dashboard specced here https://lucid.app/lucidchart/7e050b6b-5faa-4467-a8b6-e39a6ede58ee/edit?invitationId=inv_df6a7fcf-773d-496a-84e1-8bbf9a7b3832&page=0_0#
Technical Summary
UserVisit data is fetched whenever filters (rendered by django-filters) are changed, the event is detected by alpinejs change hook. Charts are initialised once at beginning, whenever data changes alpinejs updates the data for the charts.
Safety Assurance
Safety story
Tested locally and on staging environments.
Automated test coverage
QA Plan
Not planning for a QA, but Rama is going to verify on staging.
Labels & Review