Learning time does not include all attempts #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hemant10yadav Are you planning to get this PR QA'ed? |
calellowitz
requested changes
Feb 10, 2025
|
|
||
| if not created: | ||
| raise ProcessingError("Learn Module is already completed") | ||
| if completed_modules: |
There was a problem hiding this comment.
This will need logic to make sure we dont create duplicates if the same form is forwarded twice (as happened with visits). Ideally that would be enforced at the DB level.
There was a problem hiding this comment.
Added 609d76a
sravfeyn
reviewed
Feb 10, 2025
| @@ -90,6 +92,59 @@ def test_form_receiver_learn_module_create( | |||
| ).exists() | |||
|
|
|||
|
|
|||
| @pytest.mark.django_db | |||
| def test_form_receiver_multiple_module_submissions( | |||
There was a problem hiding this comment.
Making this test use parameters might make it easy to understand various cases.
Yeah I have raised the QA form for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Implemented functionality to allow users to complete the learn module multiple times. This enables capturing the learning time for each module. CCCT-638
Safety Assurance
Automated test coverage
Comprehensive test coverage has been added to ensure that a completed module is created for every submission and that only unique modules are sent to the device. This guarantees accurate progress calculation and eliminates redundancy.
Labels & Review