User Visit Review Page: Filters and Sortable fields #482
Conversation
| ) | ||
| ) | ||
| for field_name in self.form.fields.keys(): | ||
| self.form.fields[field_name].widget.attrs.update({"@change": "$refs.reviewFilterForm.submit()"}) |
There was a problem hiding this comment.
does this submit the form or just refresh it?
There was a problem hiding this comment.
this submits the review filter form whenever any filter in that form is changed.
| @@ -58,15 +59,26 @@ def show_warning(record): | |||
|
|
|||
| class UserVisitReviewFilter(FilterSet): | |||
| review_status = ChoiceFilter(choices=VisitReviewStatus.choices, empty_label="All Reviews") | |||
| user = ModelChoiceFilter(queryset=User.objects.none(), empty_label="All Users", to_field_name="username") | |||
There was a problem hiding this comment.
Im pretty confused by this user filter queryset behavior. Can you explain a bit more what is occurring? It is set to empty, then overwritten on init, but where do the values in the queryset for id__in come from, and why does it need to be done in such a way?
There was a problem hiding this comment.
The ModelChoiceFilter filter requires a query set of objects to be instantiated with, its a filter wrapper for ModelChoiceField, so I have used a .none() query set object to instantiate that filter as none query set don't make any queries to database. Further the self.queryset used in the id__in is the query set for UserVisits that this UserVisitReviewFilter works on and is passed into the filter when it is instantiated in the user_visit_review view. I hope this sounds good and please suggest any improvements you have to improve this.
|
|
||
| def __init__(self, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
| self.filters["user"].queryset = User.objects.filter(id__in=self.queryset.values_list("user_id", flat=True)) |
There was a problem hiding this comment.
Don't you need to pass any org/program filtering on this queryset?
Product Description
This PR adds filters and sortable fields for the User Visit Review page.
Technical Summary
Ticket Link
Safety Assurance
Safety story
The features included in this PR are deployed and tested on staging.
Automated test coverage
None
QA Plan
None
Labels & Review