Update Embedded App SDK docs with relationship features #7547
+95
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaber
commented
May 8, 2025
|
|
||
| | Property | Type | | ||
| |----------|-----------------------------------------------------| | ||
| | type | number | |
There was a problem hiding this comment.
I think we should also document the types, but the enum is not specified in the SDK
There was a problem hiding this comment.
Agreed! Are they the same as these in the Social SDK? Would love to have them documented here too
There was a problem hiding this comment.
Yep! I added a section for types at the bottom, pretty much copied from here
colinloretz
added
the
embedded-app-sdk
anthonydiscord
requested review from
anthonydiscord
and removed request for
markmandel
anthonydiscord
approved these changes
May 9, 2025
|
|
||
| | Property | Type | | ||
| |----------|-----------------------------------------------------| | ||
| | type | number | |
There was a problem hiding this comment.
Agreed! Are they the same as these in the Social SDK? Would love to have them documented here too
anthonydiscord
requested changes
May 9, 2025
miaber
force-pushed
the
mia/getRelationshipsDoc
branch
from
39052e8 to
17e5cf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documenting
getRelationshipscommand andRELATIONSHIP_UPDATEDevent from the latest Embedded App SDK release