Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
SpaceEEC,
iCrawl,
kyranet and
vladfrangu
deno/rest/v10/gamesdk.ts
Outdated
| /** | ||
| * https://discord.com/developers/docs/game-sdk/lobbies#update-lobby-member | ||
| */ | ||
| export type RESTPatchAPILobbyMemberJSONBody = Pick<APILobby, 'metadata'>; |
There was a problem hiding this comment.
Partial<>? Also missing result type
deno/rest/v10/gamesdk.ts
Outdated
| /** | ||
| * https://discord.com/developers/docs/game-sdk/lobbies#send-lobby-data | ||
| */ | ||
| export interface RESTPostAPILobbyDataJSONBody { |
deno/rest/v10/gamesdk.ts
Outdated
| /** | ||
| * https://discord.com/developers/docs/game-sdk/lobbies#create-lobby-search | ||
| */ | ||
| export interface RESTPostAPILobbySearchJSONBody { |
deno/rest/v10/gamesdk.ts
Outdated
| /** | ||
| * https://discord.com/developers/docs/game-sdk/store#get-entitlement | ||
| */ | ||
| export type RESTGetAPIEntitlementQuery = Pick<RESTGetAPIEntitlementsQuery, 'with_payments'>; |
There was a problem hiding this comment.
yes, this type is for the query params that can only contain with_payments
payloads/v10/gamesdk.ts
Outdated
| export enum LobbyRegion { | ||
| Atlanta = 'atlanta', | ||
| Brazil = 'brazil', | ||
| Bucharest = 'bucharest', | ||
| BuenosAires = 'buenos-aires', | ||
| Dubai = 'dubai', | ||
| Finland = 'finland', | ||
| Hongkong = 'hongkong', | ||
| India = 'india', | ||
| Japan = 'japan', | ||
| Madrid = 'madrid', | ||
| Milan = 'milan', | ||
| Montreal = 'montreal', | ||
| Newark = 'newark', | ||
| Rotterdam = 'rotterdam', | ||
| Russia = 'russia', | ||
| SantaClara = 'santa-clara', | ||
| Santiago = 'santiago', | ||
| Seattle = 'seattle', | ||
| Singapore = 'singapore', | ||
| SouthKorea = 'south-korea', | ||
| SouthAfrica = 'southafrica', | ||
| StPete = 'st-pete', | ||
| Stockholm = 'stockholm', | ||
| Sydney = 'sydney', | ||
| UsCentral = 'us-central', | ||
| UsEast = 'us-east', | ||
| UsSouth = 'us-south', | ||
| UsWest = 'us-west', | ||
| } |
There was a problem hiding this comment.
got these from this request (that btw doesn't use the same regions as /voice/regions)
There was a problem hiding this comment.
this is probably just all the possible voice regions, /voice/regions only returns the ones u can manually set voice channels to
this list can change at any time so idk, @vladfrangu do u think it should be included? this is a superset of the options for channel rtc_region (the lists arent documented anywhere)
There was a problem hiding this comment.
Lets leave these as string because voice regions will come and go and truthfully, an enum of them is not useful
3 participants
Please describe the changes this PR makes and why it should be merged:
This PR adds support for all GameSDK stuff.
I ran into many problems while writing payloads and rest files, such as doubts about Update User Achievement (this one seems not to be working) and Get User Achievements (this one I just don't understand) endpoints. So be free to correct or explain me some mistake I made 😄
Closes #68 and replaces #88.
If applicable, please reference Discord API Docs PRs or commits that influenced this PR: