Skip to content

FEATURE: Add actor deletion #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

angusmcleod
Copy link
Contributor

@angusmcleod angusmcleod commented May 12, 2025

@pmusaraj In the course of working on this I found it difficult to keep things straight without doing some structural changes.

Deletion changes

For the substantive changes in this PR, see these specs in particular:

  • spec/lib/discourse_activity_pub/ap/activity/delete_spec.rb
  • spec/lib/post_destroyer_spec.rb
  • spec/models/category_spec.rb
  • spec/models/tag_spec.rb
  • spec/requests/admin/discourse_activity_pub/actor_controller_spec.rb

For context on the approach to deletion, see further:

Structural changes

The main structural changes in this PR are:

  • Move to zeitwerk loading.
  • Add a plugin.rb helper method for AP processing (activity_pub_on) to abstract that handling a bit.
  • Organise the modifications in plugin.rb into functional groups.

@pmusaraj
Copy link
Contributor

Sorry for the delay @angusmcleod, I'll review this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants