FIX: Resolve i18n calls at render time instead of class instantiation#286
Merged
FIX: Resolve i18n calls at render time instead of class instantiation#286
Conversation
The modelTypes class field initializer calls i18n() when the class is instantiated, capturing translations at that point. This prevents Site Text overrides from being reflected since the array is built once and reused. Convert the class field to a getter so the translations are resolved fresh each time the property is accessed.
pmusaraj
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modelTypes class field initializer calls i18n() when the class is instantiated, capturing translations at that point. This prevents Site Text overrides from being reflected since the array is built once and reused.
Convert the class field to a getter so the translations are resolved fresh each time the property is accessed.
Core fix - discourse/discourse#37041