UX: make sure search banner is visible #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegangeorge
requested changes
Jun 24, 2025
| "https://github.com/discourse/discourse-showcased-categories.git", | ||
| "https://github.com/discourse/discourse-search-banner.git" | ||
| ], | ||
| "components": ["https://github.com/discourse/discourse-search-banner.git"], |
Member
There was a problem hiding this comment.
Do we still need to use this component? Could we use core's SiteSetting.enable_welcome_banner and SiteSetting.search_experience overrides similar to how we do for Horizon? This way we could remove the extension code throughout the theme completely.
Member
Author
There was a problem hiding this comment.
That's an excellent question, Keegan. I considered the same approach, but ultimately decided not to remove the "discourse-search-banner" component. For sites that already have the Mint theme installed, removing the component-specific styling would cause the layout to break. Does that make sense?
awesomerobot
approved these changes
Jun 25, 2025
keegangeorge
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEV: remove support for 'Discourse Showcased Categories'
This PR fixes the search banner that was not showing up because of recent changes in core and Advanced search banner plugin.
This PR also removes support for 'Discourse Showcased Categories' that was an optional feature but was broken for a while and was not being used.
Here's how the default theme looks now: