mastic: Implement the heavy hitters sketch from ia.cr/2024/666 #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
commented
Jan 23, 2025
Comment on lines
+350
to
+357
| // Make sure all heavy hitters are accounted for. | ||
| let num_heavy_hitters = count | ||
| .iter() | ||
| .filter(|(_weight, count)| **count >= mastic.szk.typ.threshold) | ||
| .count(); | ||
| assert_eq!(heavy_hitters.len(), num_heavy_hitters); |
There was a problem hiding this comment.
This test may flake, since bucket collisions can garble heavy hitters.
cjpatton
force-pushed
the
cjpatton/mastic-approx-hh
branch
5 times, most recently
from
71cd831 to
0c7b791
Compare
cjpatton
commented
Jan 24, 2025
Comment on lines
+203
to
+208
| // Check that each input is either a `1` or a `-1`. | ||
| input | ||
| .iter() | ||
| .copied() | ||
| .map(|x| gadgets[0].call(&[x])) | ||
| .collect() |
There was a problem hiding this comment.
A typical input length will probably be something like num_bits == 256. I wonder if we'd be better off (in terms of proof size and computation) with ParallelSum here.
That would mean we would need joint randomness and thus a larger field (Field128). I'm not sure if a larger field would pay off.
cjpatton
force-pushed
the
cjpatton/mastic-approx-hh
branch
2 times, most recently
from
da8f205 to
c279d4f
Compare
This commit adds an initial implementation of the sketching technique from ia.cr/2024/666 for approximate heavy hitters. This main advantage is that the computation requires just one round of aggregation rather than many.
cjpatton
force-pushed
the
cjpatton/mastic-approx-hh
branch
from
c279d4f to
a38929d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an initial implementation of the sketching technique from ia.cr/2024/666 for approximate heavy hitters. This main advantage is that the computation requires just one round of aggregation rather than many.