Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage for fields.py #92

Merged
merged 12 commits into from
Oct 10, 2024

Conversation

browniebroke
Copy link
Member

@browniebroke browniebroke commented Oct 10, 2024

Until the codecov app is installed on this repo, coverage can be seen here: https://app.codecov.io/gh/browniebroke/drf-excel/blob/test-coverage-fields/drf_excel%2Ffields.py

  • XLSXField
  • XLSXNumberField
  • XLSXDateField
  • XLSXListField
  • XLSXBooleanField

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@e363602). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage        ?   88.53%           
=======================================
  Files           ?        4           
  Lines           ?      349           
  Branches        ?        0           
=======================================
  Hits            ?      309           
  Misses          ?       40           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@browniebroke browniebroke marked this pull request as ready for review October 10, 2024 15:15
@FlipperPA FlipperPA merged commit dd6a7d1 into django-commons:main Oct 10, 2024
6 checks passed
@browniebroke browniebroke deleted the test-coverage-fields branch October 11, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants