Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CROSSORIGIN & django-csp handling #405

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

karolyi
Copy link
Contributor

@karolyi karolyi commented Jul 28, 2024

The crossorigin tag is necessary for cases when the loaded assets have their integrity tag set and the origin of theirs are different from that of the loading page.

Besides, there's a couple improvements in the code as well.

@karolyi karolyi changed the title Adding CROSSORIGIN handling Adding CROSSORIGIN & django-csp handling Jul 28, 2024
@karolyi
Copy link
Contributor Author

karolyi commented Jul 29, 2024

I have more ideas about immensely speeding up this module with utilizing caches, but this'll have to suffice for now.

Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but we need more tests for the new code, including error conditions.

@karolyi
Copy link
Contributor Author

karolyi commented Aug 2, 2024

Hey,

I've already provided test code that test the changes out, and using my fork in a pretty huge project, which was the reason to make the contribution in the first place.

Feel free to add those tests if you want to, this should be good to go either way.

@karolyi
Copy link
Contributor Author

karolyi commented Nov 9, 2024

bumperino

@davidjayb
Copy link

Is there any traction on getting this merged? Being able to use a nonce CSP policy would be great.

@karolyi
Copy link
Contributor Author

karolyi commented Feb 3, 2025

@davidjayb try using my fork (https://git.ksol.io/karolyi/django-webpack-loader/) and while you're at it, give a go to my rewritten integrity calculation too so you can test it as well: https://git.ksol.io/karolyi/webpack-bundle-tracker/

Here's to hoping for a quick merge, but to be honest I gave up on having the latter merged after being called names.

@rvlb rvlb self-requested a review February 12, 2025 12:44
@karolyi
Copy link
Contributor Author

karolyi commented Mar 24, 2025

I've deleted the repo on here from which I initiated the PR.

The repo with the modifications can still be found at https://git.ksol.io/karolyi/django-webpack-loader/, should anyone need it.

Also there is a setuptools error which I've fixed over there.

@karolyi
Copy link
Contributor Author

karolyi commented Mar 24, 2025

How to use my fork in requirements.txt, in case you want to use it:

django-webpack-loader @ git+https://git.ksol.io/karolyi/django-webpack-loader.git@9c6f1030b5281ce4a80e458ee8ee2b11cb517bdf

That is the latest commit, but probably you can just go with @master at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants