-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CROSSORIGIN & django-csp handling #405
base: master
Are you sure you want to change the base?
Conversation
I have more ideas about immensely speeding up this module with utilizing caches, but this'll have to suffice for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but we need more tests for the new code, including error conditions.
Hey, I've already provided test code that test the changes out, and using my fork in a pretty huge project, which was the reason to make the contribution in the first place. Feel free to add those tests if you want to, this should be good to go either way. |
bumperino |
Is there any traction on getting this merged? Being able to use a nonce CSP policy would be great. |
@davidjayb try using my fork (https://git.ksol.io/karolyi/django-webpack-loader/) and while you're at it, give a go to my rewritten integrity calculation too so you can test it as well: https://git.ksol.io/karolyi/webpack-bundle-tracker/ Here's to hoping for a quick merge, but to be honest I gave up on having the latter merged after being called names. |
I've deleted the repo on here from which I initiated the PR. The repo with the modifications can still be found at https://git.ksol.io/karolyi/django-webpack-loader/, should anyone need it. Also there is a setuptools error which I've fixed over there. |
How to use my fork in requirements.txt, in case you want to use it:
That is the latest commit, but probably you can just go with @master at the end. |
The
crossorigin
tag is necessary for cases when the loaded assets have theirintegrity
tag set and the origin of theirs are different from that of the loading page.Besides, there's a couple improvements in the code as well.