Skip to content

skip to main #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

skip to main #2054

wants to merge 3 commits into from

Conversation

moshe742
Copy link

No description provided.

moshe742 and others added 3 commits April 27, 2025 16:41
added a comment to add a co-author

Co-authored-by: Howard Cox <[email protected]>
Copy link
Member

@sabderemane sabderemane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have just a minor change

@@ -86,6 +87,7 @@
</ul>
{% endif %}
{% endblock %}
<div id="main-content"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add the id on the main tag instead? This will avoid adding a new tag, especially a div only for that and the messages will be visible.

@ulgens
Copy link
Contributor

ulgens commented Apr 27, 2025

Possibly relates to #1367

@sabderemane
Copy link
Member

Relates to #1367

Yes @ulgens, the purpose is to close this issue and add the co-author of the initial PR to this one

@sabderemane
Copy link
Member

Hi @moshe742, do you have still time to work on this one?

@adamzap
Copy link
Member

adamzap commented May 16, 2025

@moshe742 Could you address the comments on this PR if you're still interested in working on it? Otherwise it will be closed in a week. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants