-
-
Notifications
You must be signed in to change notification settings - Fork 996
skip to main #2054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
skip to main #2054
Conversation
added a comment to add a co-author Co-authored-by: Howard Cox <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have just a minor change
@@ -86,6 +87,7 @@ | |||
</ul> | |||
{% endif %} | |||
{% endblock %} | |||
<div id="main-content"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add the id on the main tag instead? This will avoid adding a new tag, especially a div only for that and the messages will be visible.
Possibly relates to #1367 |
Hi @moshe742, do you have still time to work on this one? |
@moshe742 Could you address the comments on this PR if you're still interested in working on it? Otherwise it will be closed in a week. Thanks! |
No description provided.