Android: match add/edit task UI with web form#261
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Android task add/edit form to match the web UI’s feature set, including due date gating, recurrence configuration, end dates, and notification trigger options, and propagates the new fields through navigation into the request models.
Changes:
- Expanded
TaskFormScreenwith due date + repeat/custom recurrence UI, scheduling preferences, end date, and notifications. - Updated
onSaveplumbing to passendDate+notificationintoCreateTaskReq/UpdateTaskReq. - Adjusted recurrence chip display formatting in the task list.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| android/app/src/main/java/com/dkhalife/tasks/ui/screen/TaskListScreen.kt | Tweaks recurrence chip rendering and recurrence text formatting. |
| android/app/src/main/java/com/dkhalife/tasks/ui/screen/TaskFormScreen.kt | Major UI expansion to reach parity with the web task form, including new date/time pickers and recurrence/notification sections. |
| android/app/src/main/java/com/dkhalife/tasks/ui/navigation/AppNavigation.kt | Wires new endDate and notification fields from the form into create/update requests. |
android/app/src/main/java/com/dkhalife/tasks/ui/screen/TaskFormScreen.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/java/com/dkhalife/tasks/ui/screen/TaskFormScreen.kt
Show resolved
Hide resolved
android/app/src/main/java/com/dkhalife/tasks/ui/screen/TaskFormScreen.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Android task add/edit form (
TaskFormScreen) to have full feature parity with the web UI.New form sections
DatePickerDialog→TimePickerDialog). All other sections are gated behind this checkbox.Propagation
endDateandnotificationare now passed through theonSavelambda intoCreateTaskReq/UpdateTaskReq. No model changes were needed — all fields already existed in the data layer.