Skip to content

Conversation

@trivialfis
Copy link
Member

@hcho3
Copy link
Collaborator

hcho3 commented Nov 20, 2025

Do you have a reason to believe that fetching gtest from Apt would lead to less flakiness than fetching it from GitHub?

@trivialfis
Copy link
Member Author

No reason. But in general, having it handled by a dependency manager makes things easier. For instance, we can cache them in a docker image if needed. Also, we don't have to build from source everytime. I would like to replace the dmlc gtest whenever the chance arises.

@hcho3
Copy link
Collaborator

hcho3 commented Nov 20, 2025

If so, let's use Conda to install gtest. This way, we can also use it for MacOS and Windows as well.

@trivialfis trivialfis marked this pull request as draft November 21, 2025 09:28
@trivialfis trivialfis requested a review from Copilot November 21, 2025 09:43
Copilot finished reviewing on behalf of trivialfis November 21, 2025 09:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the gtest-cpu-nonomp CI workflow to use a conda-provided GTest package instead of fetching GTest through CMake via the dmlc-core submodule. This change addresses a failure in the CI pipeline where CMake's automatic GTest fetch was failing.

  • Removed -DUSE_DMLC_GTEST=ON flag from the CMake build configuration
  • Switched from apt-get installation to conda environment setup with miniforge
  • Added proper bash shell configuration for conda environment activation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ops/pipeline/build-test-cpu-nonomp.sh Removed the -DUSE_DMLC_GTEST=ON CMake flag to use system-provided GTest instead of dmlc-core's bundled version
.github/workflows/misc.yml Replaced apt-get installation with miniforge-setup action, configured proper bash shell for conda, and added cpp_test conda environment setup

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@trivialfis trivialfis requested a review from hcho3 November 21, 2025 09:47
@trivialfis trivialfis marked this pull request as ready for review November 21, 2025 13:11
@trivialfis trivialfis merged commit d664e11 into dmlc:master Nov 24, 2025
69 checks passed
@trivialfis trivialfis deleted the ci-use-apt-gtest branch November 24, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants