Feat/#18 로그인, 회원가입( 정보입력 ) 페이지 퍼블리싱 #20
Open
+253
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
leeleeleeleejun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
close #18
📝작업 내용
( 로그인, 온보딩 페이지에서 공통되는 부분 )
( textarea만 수정되어 있길래 input도 추가 수정했습니다)
화면이 작은 모니터에서 사용 시 표시될 스크롤바 작업
( height가 줄어드는 상황이 있어 디자인과 달라져 min-h 로 수정했습니다 )
💬리뷰 요구사항
login 페이지와 signup 페이지의 공통 레이아웃을 적용하기 위해, 현재 signup 디렉토리를 login 디렉토리 하위로 배치했습니다.
이로 인해 온보딩 페이지의 URL이
login/signup으로 표시되는데, 어색하게 느껴지는지 궁금합니다!어색하다면
(auth)디렉토리 생성 후 하위 디렉토리로 이동시키겠습니다