책 평가 리스트를 조회한다. #77
Open
책 평가 리스트를 조회한다. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
resolves #76
작업 내용
리뷰 요구사항
확장성을 고려해서 EvaluationType, EvaluationKeyword을 구성했는데 괜찮을까요?
EvaluationType
이렇게 구성한 이유는 새로운 키워드가 등장에 대해서 유연하게 대처하게 하도록 하고싶었어요.
EvaluationKeyword
DB 테이블처럼 구조가 잡혀있는 형태에요!
만약에
MemberBookEntity내부에 배열 형태의 컬럼(ex. [101, 103, 106, 204])이 존재한다면 변환하기 편할 것 같다고 생각이 들었어요.