Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update readme from mariadb with port binding, tags, remove double spaces and informations #2552

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

felipementel
Copy link
Contributor

@felipementel felipementel commented Mar 6, 2025

This pull request includes updates to the mariadb documentation and configuration files to improve clarity and compatibility, as well as to specify versions for certain images.

Documentation improvements:

  • mariadb/content.md: Added an important note about the %%IMAGE%% tags to highlight the latest and lts versions.
  • mariadb/content.md: Updated the Docker compose command to use docker compose instead of docker-compose for consistency with the latest Docker CLI.
  • mariadb/content.md: Added a section on port binding to explain how to expose the container port to the host port using the -p argument in the docker run command.

Configuration updates:

  • mariadb/stack.yml: Specified the image versions for mariadb and adminer to ensure consistency and compatibility. The mariadb image is updated to 11.7-ubi and adminer to 4.17.1.
  • mariadb/stack.yml: Remove docker compose version on file header - the docker compose version is obsolete

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few notes 👍

I'll also explicitly CC the mariadb image maintainers: @grooverdan @dbart @fauust

Copy link
Contributor

@grooverdan grooverdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup.

@felipementel
Copy link
Contributor Author

@tianon, @grooverdan
There are other points to yours check?

felipementel

This comment was marked as duplicate.

Copy link
Contributor Author

@felipementel felipementel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to make any further adjustments for analysis and approval?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants