-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update readme from mariadb with port binding, tags, remove double spaces and informations #2552
base: master
Are you sure you want to change the base?
docs: update readme from mariadb with port binding, tags, remove double spaces and informations #2552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few notes 👍
I'll also explicitly CC the mariadb
image maintainers: @grooverdan @dbart @fauust
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the cleanup.
@tianon, @grooverdan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I need to make any further adjustments for analysis and approval?
This pull request includes updates to the
mariadb
documentation and configuration files to improve clarity and compatibility, as well as to specify versions for certain images.Documentation improvements:
mariadb/content.md
: Added an important note about the%%IMAGE%%
tags to highlight thelatest
andlts
versions.mariadb/content.md
: Updated the Docker compose command to usedocker compose
instead ofdocker-compose
for consistency with the latest Docker CLI.mariadb/content.md
: Added a section on port binding to explain how to expose the container port to the host port using the-p
argument in thedocker run
command.Configuration updates:
mariadb/stack.yml
: Specified the image versions formariadb
andadminer
to ensure consistency and compatibility. Themariadb
image is updated to11.7-ubi
andadminer
to4.17.1
.mariadb/stack.yml
: Remove docker compose version on file header - the docker compose version is obsolete