Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt compose-go/v2 #11207

Merged
merged 3 commits into from
Dec 5, 2023
Merged

adopt compose-go/v2 #11207

merged 3 commits into from
Dec 5, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Nov 20, 2023

What I did
adopt compose-go/v2

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, glours, milas and laurazard and removed request for a team November 20, 2023 11:04
@ndeloof ndeloof force-pushed the compose-go-v2 branch 9 times, most recently from ecd997e to f4e1c3f Compare November 27, 2023 10:12
@ndeloof ndeloof force-pushed the compose-go-v2 branch 4 times, most recently from 2ab960d to 89e6e9e Compare November 29, 2023 08:26
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (8026d0e) 56.88% compared to head (4e7034c) 56.52%.

Files Patch % Lines
pkg/compose/publish.go 0.00% 6 Missing ⚠️
cmd/compose/build.go 62.50% 2 Missing and 1 partial ⚠️
cmd/compose/create.go 62.50% 2 Missing and 1 partial ⚠️
pkg/api/api.go 40.00% 3 Missing ⚠️
pkg/compose/create.go 57.14% 0 Missing and 3 partials ⚠️
pkg/compose/pull.go 75.00% 3 Missing ⚠️
cmd/compose/scale.go 60.00% 1 Missing and 1 partial ⚠️
cmd/compose/up.go 71.42% 1 Missing and 1 partial ⚠️
cmd/compose/config.go 0.00% 1 Missing ⚠️
cmd/compose/options.go 75.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11207      +/-   ##
==========================================
- Coverage   56.88%   56.52%   -0.36%     
==========================================
  Files         133      133              
  Lines       11513    11512       -1     
==========================================
- Hits         6549     6507      -42     
- Misses       4326     4364      +38     
- Partials      638      641       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndeloof ndeloof force-pushed the compose-go-v2 branch 5 times, most recently from 0d1696d to 83d2772 Compare November 30, 2023 15:15
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a couple small places where I think it's using a value where it needs a pointer

cmd/compose/options.go Show resolved Hide resolved
pkg/compose/build.go Outdated Show resolved Hide resolved
pkg/compose/compose.go Show resolved Hide resolved
Copy link
Contributor

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a suggestion and a small callout

pkg/compose/compose.go Show resolved Hide resolved
pkg/compose/pull.go Show resolved Hide resolved
@ndeloof ndeloof merged commit 26aca86 into docker:main Dec 5, 2023
26 checks passed
@ndeloof ndeloof deleted the compose-go-v2 branch December 5, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants