-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adopt compose-go/v2 #11207
adopt compose-go/v2 #11207
Conversation
ecd997e
to
f4e1c3f
Compare
2ab960d
to
89e6e9e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11207 +/- ##
==========================================
- Coverage 56.88% 56.52% -0.36%
==========================================
Files 133 133
Lines 11513 11512 -1
==========================================
- Hits 6549 6507 -42
- Misses 4326 4364 +38
- Partials 638 641 +3 ☔ View full report in Codecov by Sentry. |
0d1696d
to
83d2772
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just a couple small places where I think it's using a value where it needs a pointer
83d2772
to
bfdb619
Compare
1398882
to
9d4d65c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just a suggestion and a small callout
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
9d4d65c
to
4e7034c
Compare
What I did
adopt compose-go/v2
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did
![image](https://private-user-images.githubusercontent.com/132757/285797084-024acead-4a7e-491b-a29d-de915c03861f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MzE5ODIsIm5iZiI6MTczOTQzMTY4MiwicGF0aCI6Ii8xMzI3NTcvMjg1Nzk3MDg0LTAyNGFjZWFkLTRhN2UtNDkxYi1hMjlkLWRlOTE1YzAzODYxZi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QwNzI4MDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kMWUyOTE1MDY0NmMwYTE3MzcxZmE0ZTc0ZGJmY2E1MzUxYWRmOWQ1MWNjMjk2YjQ1YmIwMjJjZWJkYWM2ZDU5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.rWQrUVoa3ngFniYnJU-eJTl6rx61CT00TkD1DS7WIjI)