Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golang to version v1.21.6 #11331

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

glours
Copy link
Contributor

@glours glours commented Jan 10, 2024

What I did
Bump Golang to version v1.21.6

go1.21.6 (released 2024-01-09) includes fixes to the compiler, the runtime, and the crypto/tls, maps, and runtime/pprof packages. See the Go 1.21.6 milestone on our issue tracker for details.

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Guillaume Lours <[email protected]>
@glours glours self-assigned this Jan 10, 2024
@glours glours requested review from ndeloof, milas and jhrotko January 10, 2024 17:05
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2bf2b22) 56.74% compared to head (8767474) 56.61%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11331      +/-   ##
==========================================
- Coverage   56.74%   56.61%   -0.14%     
==========================================
  Files         134      134              
  Lines       11448    11448              
==========================================
- Hits         6496     6481      -15     
- Misses       4330     4342      +12     
- Partials      622      625       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Comment on lines 19 to 20
ARG XX_VERSION=1.2.1
ARG GOLANGCI_LINT_VERSION=v1.54.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but there's newer versions of xx (v1.3.0) and GolangCI-lint (v1.55.2) that we may want to update as well.

For xx; I'm running into an issue when cross-compiling in docker/docker-credential-helpers#310, so just a heads-up on that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up, I'll open a couple new PRs for these

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golangci-lint PR @ #11332

Following the xx discussion, same issue on Compose side:

 > [linux/arm64->darwin/amd64 build 1/1] RUN --mount=type=bind,target=.     --mount=type=cache,target=/root/.cache     --mount=type=cache,target=/go/pkg/mod     --mount=type=bind,from=osxcross,src=/osxsdk,target=/xx-sdk     xx-go --wrap &&     if [ "$(xx-info os)" == "darwin" ]; then export CGO_ENABLED=1; fi &&     make build GO_BUILDTAGS="e2e" DESTDIR=/out &&     xx-verify --static /out/docker-compose:
1.355 GO111MODULE=on go build  -trimpath -tags "e2e" -ldflags "-w -X github.com/docker/compose/v2/internal.Version=v2.24.0-birthday.10-39-gf5c53c2d0.m" -o "/out/docker-compose" ./cmd
201.4 # github.com/docker/compose/v2/cmd
201.4 /usr/local/go/pkg/tool/linux_arm64/link: running x86_64-apple-macos10.6-clang failed: exit status 1
201.4 /usr/bin/x86_64-apple-macos10.6-ld: line 9: sigtool-gensig: not found
201.4 clang: error: unable to execute command: No such file or directory
201.4 clang: error: linker command failed due to signal (use -v to see invocation)
201.4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking! /cc @crazy-max

@milas milas merged commit 1cfeda7 into docker:main Jan 10, 2024
26 checks passed
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

temenuzhka-thede pushed a commit to temenuzhka-thede/compose that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants