Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnf5 have no config-manager #21037

Merged
merged 1 commit into from
Oct 3, 2024
Merged

dnf5 have no config-manager #21037

merged 1 commit into from
Oct 3, 2024

Conversation

sciencegenome
Copy link
Contributor

in the fedora 40 and above dnf5 is implemented and hence the dnf command listed in the docker will not work. I have updated the dnf command to dnf-3 as then you will be able to use the same.

Description

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

in the fedora 40 and above dnf5 is implemented and hence the dnf command listed in the docker will not work. I have updated the dnf command to dnf-3 as then you will be able to use the same.
@github-actions github-actions bot added area/engine Issue affects Docker engine/daemon area/install Relates to installing a product labels Sep 30, 2024
Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 09ea80a
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66fb0cebe18685000818f50f
😎 Deploy Preview https://deploy-preview-21037--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thaJeztah
Copy link
Member

Thanks! We published packages for Fedora 40, but it's not yet release, so we did not yet update the docs. Perhaps instead we should differentiate for Fedora 40 and up (dnf5) until Fedora 39 and older are EOL. For that we should check though if the bugs in dnf5 were fixed, as there was an issue in the current version of the Fedora 40 (beta) image that caused some things to fail; https://github.com/docker/docker-install/blob/6d51e2cd8c04b38e1c2237820245f4fc262aca6c/install.sh#L560-L569

(That bug was fixed, but was not yet included in the current fedora:40 images);

@sciencegenome
Copy link
Contributor Author

sciencegenome commented Oct 1, 2024

Thank you and actually it is not about the Fedora 40. It is also about the variants of the Fedora such as SilverBlue and Ultramarine and Nobara, so people might find that docker is not working so i added it. If you merge then it would be ok or else we can close this comment. Adding a tag to that will actually help as some people ares still using the old version of the RedHat.

Evening to all,
Gaurav

Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think explicitly calling dnf-3 seems like a good option for now, to retain compatibility with current and adjacent distros like silverblue, while also ensuring that the instruction remains as simple as possible. Fedora 39 reaches EOL on November 12th, I propose that we update this instruction to use dnf5 then, with a caution to users that do not yet have dnf5 to upgrade.

@dvdksn dvdksn requested a review from thaJeztah October 2, 2024 09:29
@sciencegenome
Copy link
Contributor Author

@dvdksn Thank you David and thank you approving the changes. This will actually help even for those containers which are using the older version of the fedora. I have just pushed a new fedora devops here https://github.com/codecreatede/fedora-devops and in the second release intgerating the dnf3 so that it will be easier on the old systems.

Basically i will write a uname-a and then strings.Split(exec.Command("uname", "-a") and if the [0] is greater than time.Date().String then execute the dnf5 else dnf3.

Thank you approving the changes to the docker docs.

Tack,
Gaurav

@sciencegenome sciencegenome changed the title added proper docker install as dnf5 have no config-manager dnf5 have no config-manager Oct 2, 2024
@dvdksn dvdksn merged commit 64b2c04 into docker:main Oct 3, 2024
14 checks passed
@sciencegenome
Copy link
Contributor Author

Thank you David for the merge into the main branch. @dvdksn

@thaJeztah
Copy link
Member

Fedora 39 reaches EOL on November 12th, I propose that we update this instruction to use dnf5 then

I realized I had an "off by one"; it's Fedora 41 that uses dnf5 as default, which means we need to wait for Fedora 40 to reach EOL

@sciencegenome
Copy link
Contributor Author

@thaJeztah than you and it happens. I am happy that you have merged the pull request. this is for the other users also and i thank you for the interaction and i look forward to interact with you all more. Have a good evening all, Gaurav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issue affects Docker engine/daemon area/install Relates to installing a product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants