-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new genai rag guide #21703
base: main
Are you sure you want to change the base?
new genai rag guide #21703
Conversation
Signed-off-by: Your Name <[email protected]>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I appreciate your effort; RAG is an important
topic, and expanding our documentation on it can add significant value for our
readers. However, I think this guide could benefit from more focus and
refinement to align with the needs of our audience and complement our existing
materials. Here are my thoughts:
- The guide's purpose is unclear. It's important to define what this guide
offers that the existing RAG guide does not. It seems like you want to focus
on RAG with graph databases and Neo4j in particular. If the goal of the guide
is to explore and demonstrate the benefits of this technology in particular,
consider a way of doing that by example. E.g., by comparing this approach to
using a vector database. - Th structure and flow of the article feels fragmented and doesn't follow a
logical progression. For instance, introducing graph databases before RAG
seems out of place, especially for readers unfamiliar with the primary topic.
Start with RAG and its benefits, then explain how graph databases fit into
the picture. - The "Case Study" section is disconnected from the rest of the content. I
would suggest removing it. Or if you want to keep it, integrate it into a
narrative that supports the guide. - Several sections lack detail and direction. The technical instructions for
setting up the stack are too sparse to be genuinely useful. I'm missing
detailed, hands-on workflows and concrete examples that readers can follow
and apply.
@dvdksn I did the changes, can you take another look. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Expeto.
Added some style suggestions. Overall, it's looking good. The last section is a hard to make sense of, so I suggest elaborating more, or replace it with a summary of what was covered.
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The build check now has some errors. Added some suggestions to fix 'em.
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Thanks for the final touch. |
Description
Added a new guide about RAG with genAI which also explains how RAG actually work
Reviews