-
Notifications
You must be signed in to change notification settings - Fork 7.7k
docs: Add language-specific guide for Deno runtime #21893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @dvdksn, You can fork the repo https://github.com/Pradumnasaraf/deno-docker to the dockersamples. I have mentioned the URL is the docs! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Pradumnasaraf. Overall looks good to me. Left some grammar nits and the Kubernetes port config didn't work.
I'm working on getting the sample repo forked to dockersamples as I don't have permission in that org. I'll update here when it's forked.
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Hey, Thanks for the review, @craig-osterhout. I have updated the the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There are some vale vocab nits that I'll follow up with.
Thank you. |
Description
Add a language-specific guide for Deno.
Reviews