fix: use correct variable metrics-addr#22616
Open
ranomier wants to merge 1 commit intodocker:mainfrom
Open
Conversation
rename metrics-address to metrics-addr
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thaJeztah
requested changes
May 12, 2025
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
I don't think this change is correct, but perhaps you have more context?
|
|
||
| To configure the Docker daemon as a Prometheus target, you need to specify the | ||
| `metrics-address` in the `daemon.json` configuration file. This daemon expects | ||
| `metrics-addr` in the `daemon.json` configuration file. This daemon expects |
Member
There was a problem hiding this comment.
I went checking, but looks like metrics-addr is the correct name of the field in the daemon.json configuration file;
https://github.com/moby/moby/blob/7979b3d46b20316da9a7966d610e1e75bf3297c0/daemon/config/config.go#L241
MetricsAddress string `json:"metrics-addr"`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rename metrics-address to metrics-addr
Description
just a little correction on variable naming
Related issues or tickets
Reviews