Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new SqlOutputWalker class in the ORM #2895

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Nov 12, 2024

Fixes #2892

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.62%. Comparing base (950d7c0) to head (703680f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...leteable/Query/TreeWalker/SoftDeleteableWalker.php 83.33% 2 Missing ⚠️
...c/Tool/ORM/Walker/CompatSqlOutputWalkerForOrm2.php 50.00% 2 Missing ⚠️
...c/Tool/ORM/Walker/CompatSqlOutputWalkerForOrm3.php 50.00% 2 Missing ⚠️
...ranslatable/Query/TreeWalker/TranslationWalker.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2895      +/-   ##
==========================================
- Coverage   78.66%   78.62%   -0.04%     
==========================================
  Files         168      171       +3     
  Lines        8760     8782      +22     
==========================================
+ Hits         6891     6905      +14     
- Misses       1869     1877       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbabker mbabker force-pushed the sqlwalker-deprecation branch from 0a88bfa to 6db37f9 Compare November 12, 2024 01:07
@mbabker mbabker marked this pull request as ready for review November 12, 2024 01:09
@mbabker mbabker changed the title [WIP] Add support for new SqlOutputWalker class in the ORM Add support for new SqlOutputWalker class in the ORM Nov 12, 2024
@mbabker mbabker force-pushed the sqlwalker-deprecation branch from 6db37f9 to b0859d8 Compare January 14, 2025 01:35
@mbabker mbabker force-pushed the sqlwalker-deprecation branch from b0859d8 to 8ae39a6 Compare January 14, 2025 01:51
@phansys phansys merged commit 16ab390 into doctrine-extensions:main Jan 14, 2025
21 of 23 checks passed
@phansys
Copy link
Collaborator

phansys commented Jan 14, 2025

Thank you @mbabker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Translatable] Deprecation notice: TranslationWalker should implement OutputWalker
2 participants