Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHP 8.4 in Docker environment and the remaining CI jobs #2899

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Use PHP 8.4 in Docker environment and the remaining CI jobs #2899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .docker/php/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1

ARG PHP_VERSION=8.2-cli
ARG PHP_VERSION=8.4-cli

FROM composer:2 AS composer

Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/coding-standards.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
uses: "shivammathur/setup-php@v2"
with:
coverage: "none"
php-version: "8.3"
php-version: "8.4"

- name: "Install dependencies with Composer"
uses: "ramsey/composer-install@v3"
Expand All @@ -28,6 +28,8 @@ jobs:

- name: "Run PHP-CS-Fixer"
run: "vendor/bin/php-cs-fixer fix --ansi --verbose --diff --dry-run"
env:
PHP_CS_FIXER_IGNORE_ENV: 1

rector:
name: "Rector"
Expand Down
2 changes: 1 addition & 1 deletion compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ services:
target: php
dockerfile: ./.docker/php/Dockerfile
args:
PHP_VERSION: ${PHP_VERSION:-8.3-cli}
PHP_VERSION: ${PHP_VERSION:-8.4-cli}
volumes:
- .:/var/www
working_dir: /var/www
Expand Down