Support doctrine/persistence 4.0 #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2913 +/- ##
==========================================
- Coverage 78.64% 78.63% -0.01%
==========================================
Files 171 171
Lines 8775 8771 -4
==========================================
- Hits 6901 6897 -4
Misses 1874 1874 ☔ View full report in Codecov by Sentry. |
mbabker
commented
Feb 1, 2025
Comment on lines
+129
to
+134
| static fn () => new ArrayCollection( | ||
| $manager->getRepository($class) | ||
| ->findBy([ | ||
| $identifier => $id, | ||
| ]); | ||
|
|
||
| return new ArrayCollection(is_array($results) ? $results : $results->toArray()); | ||
| } | ||
| ]) | ||
| ) |
There was a problem hiding this comment.
Persistence 4.0 adds the array return type to ObjectRepository::findBy(), so the is_array() check isn't needed anymore and I've just simplified this down to an arrow function. Same below.
mbabker
force-pushed
the
persistence-4
branch
from
1ce106d to
6c21284
Compare
Done |
|
Thank you @mbabker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just as advertised