Bump ORM requirements, fix translation walker handling of paginated queries #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2920 +/- ##
==========================================
- Coverage 78.63% 78.53% -0.10%
==========================================
Files 171 168 -3
Lines 8771 8760 -11
==========================================
- Hits 6897 6880 -17
- Misses 1874 1880 +6 ☔ View full report in Codecov by Sentry. |
mbabker
force-pushed
the
translation-limit-fix
branch
from
aec4f6c to
8fc9664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2917
Note that the ORM bump here isn't strictly necessary, but in all honesty, it looks to massively simplify the patch because of the changes in the root
SqlWalkerclass which brought about theSqlOutputWalkerclass. I think the trick if you're looking for a patch that doesn't bump the ORM dependency range boils down to having the code use thecreateSqlForFinalizermethod for the newer releases andwalkSelectStatementfor the older ones to do the actual AST to SQL transformation. I can figure that out if the bump is deemed too much but simplifying the compat layer fixes this just as effectively.