Lowered Psalm level to 3 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Nov 5, 2021
| @@ -351,6 +350,7 @@ protected function hydrateByValue(array $data, $object) | |||
|
|
|||
| if ($metadata->hasAssociation($field)) { | |||
| $target = $metadata->getAssociationTargetClass($field); | |||
| assert($target !== null); | |||
There was a problem hiding this comment.
This is a sign that we should have a method that throws instead of returning null
There was a problem hiding this comment.
Above assert code is failing for mongoDB, when we are using EmbedMany argument without target document locally.
According to documentation, EmbedMany without target document is allowed to embed different documents in same field.(https://www.doctrine-project.org/projects/doctrine-mongodb-odm/en/2.7/reference/embedded-mapping.html#mixing-document-types)
Does this assert check is really needed as null value is also accepted for mongodb?
Created new issue for the same #84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required only a few class-string changes to pass.
Once change that might look surprising:
This shouldn't cause any BC breaks, since
$targetis filled from$metadata->getAssociationTargetClass($field);, which does not return leading slashs. I think this is still a relict from very early orm versions.