fix: MultiSelectElement does not allow for options w/ { id: '0' } #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The failing CI stage relates to a type-check error which is introduced in a previous commit. Once that's solved, this PR should be updated, and it should pass without issues. |
|
released with the latest version thx for your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that with API generated enum types which initialize at index
0, specificallyMultiSelectElementtends to misbehave. After some digging I realised that a logical OR operation when rendering chosenoptionswould consider the value'0'to be falsy, and attempt to render the whole item fromoptionsinstead of just its value. It subsequently causes[object Object]to be rendered, allows for selecting said entry more than once without being disabled, and whenshowChipsis set to true, it would even outright crash the renderer.I've changed the operation to be null-coalescing instead, and updated Storybook to advertise the change.
If there's anything I need to clarify, don't hesitate to ask.