Stalker texture type fix #4704
Merged
Stalker texture type fix #4704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4703
The actual bug was an off-by-one bug but I also made it exclude the displacement map sampler in general.
We don't actually implement the displacement feature and I hope no game actually uses it but better safe than sorry.
The second commit tries to slightly clean up the sampler slot mess and make it more clear which functions take in a sampler slot counted the way the API does it and which one takes in a sampler slot counted the way we do it.
Hopefully that will make bugs like this one a bit less likely (but probably wont).