Skip to content

Remove UserHasSuperAccess as Doltgres now has built-in authorization for Dolt stored procedures #10159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elianddb wants to merge 6 commits into
base: main
Choose a base branch
from
+98 −32
Open

Remove UserHasSuperAccess as Doltgres now has built-in authorization for Dolt stored procedures #10159

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3655b40
mv priv check to var
elianddb Dec 3, 2025
7342810
rm UserHasSuperAccess and move to doltgresql
elianddb Dec 3, 2025
d7cf4b6
add dolt adapter to standardize table overwrites by integrators
elianddb Dec 5, 2025
752db82
add dolt table specific adapter registry for integrators
elianddb Dec 6, 2025
cd084b0
rm extra default adapter and normalize internal alias instead
elianddb Dec 8, 2025
921d8a8
amend func docs
elianddb Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions go/libraries/doltcore/sqle/dprocedures/dolt_backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,8 @@ func doltBackup(ctx *sql.Context, args ...string) (sql.RowIter, error) {
return nil, err
}

if sqlserver.RunningInServerMode() {
// TODO(elianddb): DoltgreSQL needs an auth handler for stored procedures, i.e. AuthType_CALL, but for now we use
// this. dolt_backup already requires admin privilege on GMS due to its potentially destructive nature.
privileges, counter := ctx.GetPrivilegeSet()
if counter == 0 || !privileges.Has(sql.PrivilegeType_Super) {
return nil, sql.ErrPrivilegeCheckFailed.New(ctx.Session.Client().User)
}
if apr.ContainsAny(cli.AwsParams...) {
return nil, fmt.Errorf("AWS parameters are unavailable when running in server mode")
}
if sqlserver.RunningInServerMode() && apr.ContainsAny(cli.AwsParams...) {
return nil, fmt.Errorf("AWS parameters are unavailable when running in server mode")
}

if apr.NArg() == 0 || (apr.NArg() == 1 && apr.Contains(cli.VerboseFlag)) {
Expand Down
Loading