Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CliContext interface update. NoOp #1097

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

macneale4
Copy link
Contributor

Account for interface change in Dolt: dolthub/dolt#8708

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Main PR
covering_index_scan_postgres 350.09/s 350.07/s -0.1%
index_join_postgres 152.65/s 153.43/s +0.5%
index_join_scan_postgres 182.00/s 182.56/s +0.3%
index_scan_postgres 12.66/s 12.41/s -2.0%
oltp_point_select 2755.01/s 2799.17/s +1.6%
oltp_read_only 1863.63/s 1883.24/s +1.0%
select_random_points 110.39/s 111.09/s +0.6%
select_random_ranges 132.64/s 133.51/s +0.6%
table_scan_postgres 11.95/s 11.76/s -1.6%
types_table_scan_postgres 5.66/s 5.60/s -1.1%

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Main PR
Total 42090 42090
Successful 15351 15351
Failures 26739 26739
Partial Successes1 5234 5234
Main PR
Successful 36.4718% 36.4718%
Failures 63.5282% 63.5282%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@macneale4 macneale4 merged commit 55c7b8f into main Jan 2, 2025
18 checks passed
@macneale4 macneale4 deleted the macneale4/clictx-interface branch January 2, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants