Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for parsing VACUUM statements, as a no-op #1120

Merged
merged 20 commits into from
Jan 15, 2025
Merged

Support for parsing VACUUM statements, as a no-op #1120

merged 20 commits into from
Jan 15, 2025

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Jan 15, 2025

No description provided.

@zachmu zachmu requested a review from Hydrocharged January 15, 2025 01:34
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Main PR
covering_index_scan_postgres 366.02/s 364.81/s -0.4%
index_join_postgres 153.16/s 150.63/s -1.7%
index_join_scan_postgres 182.83/s 183.45/s +0.3%
index_scan_postgres 12.33/s 12.44/s +0.8%
oltp_point_select 2780.19/s 2771.84/s -0.4%
oltp_read_only 1866.54/s 1827.39/s -2.1%
select_random_points 111.24/s 112.83/s +1.4%
select_random_ranges 127.57/s 132.93/s +4.2%
table_scan_postgres 11.73/s 11.47/s -2.3%
types_table_scan_postgres 5.55/s 5.49/s -1.1%

Copy link
Contributor

Main PR
Total 42090 42090
Successful 15442 15557
Failures 26648 26533
Partial Successes1 5236 5226
Main PR
Successful 36.6880% 36.9613%
Failures 63.3120% 63.0387%

${\color{lightgreen}Progressions (125)}$

brin

QUERY: VACUUM brintest;
QUERY: VACUUM ANALYZE brin_test;
QUERY: VACUUM brintest_3;

brin_bloom

QUERY: VACUUM brintest_bloom;
QUERY: VACUUM ANALYZE brin_test_bloom;

brin_multi

QUERY: VACUUM brintest_multi;
QUERY: VACUUM ANALYZE brin_test_multi;

btree_index

QUERY: VACUUM delete_test_table;

compression

QUERY: VACUUM FULL cmdata;

create_index

QUERY: VACUUM FULL concur_heap;
QUERY: VACUUM FULL concur_heap;

gin

QUERY: vacuum gin_test_tbl;
QUERY: vacuum gin_test_tbl;
QUERY: vacuum gin_test_tbl;
QUERY: vacuum t_gin_test_tbl;

gist

QUERY: vacuum analyze gist_point_tbl;
QUERY: vacuum analyze gist_tbl;

hash_index

QUERY: VACUUM hash_split_heap;

indirect_toast

QUERY: VACUUM FREEZE indtoasttest;
QUERY: VACUUM FREEZE indtoasttest;

join

QUERY: vacuum analyze j3;

numeric

QUERY: VACUUM ANALYZE num_exp_add;
QUERY: VACUUM ANALYZE num_exp_sub;
QUERY: VACUUM ANALYZE num_exp_div;
QUERY: VACUUM ANALYZE num_exp_mul;
QUERY: VACUUM ANALYZE num_exp_sqrt;
QUERY: VACUUM ANALYZE num_exp_ln;
QUERY: VACUUM ANALYZE num_exp_log10;
QUERY: VACUUM ANALYZE num_exp_power_10_ln;

reloptions

QUERY: VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) reloptions_test;
QUERY: VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) reloptions_test;

sanity_check

QUERY: VACUUM;

spgist

QUERY: vacuum spgist_point_tbl;
QUERY: vacuum spgist_point_tbl;

stats_ext

QUERY: VACUUM ANALYZE stxdinh, stxdinh1, stxdinh2;
QUERY: VACUUM ANALYZE stxdinh, stxdinh1, stxdinh2;
QUERY: VACUUM ANALYZE stxdinp;

test_setup

QUERY: VACUUM CHAR_TBL;
QUERY: VACUUM FLOAT8_TBL;
QUERY: VACUUM INT2_TBL;

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

server/ast/convert.go Show resolved Hide resolved
server/ast/vacuum.go Show resolved Hide resolved
@zachmu zachmu merged commit c6d84fe into main Jan 15, 2025
14 checks passed
@zachmu zachmu deleted the zachmu/vacuum branch January 15, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants