Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cockroach errors.Errorf for one-off errors #1145

Merged
merged 2 commits into from
Jan 24, 2025
Merged

use cockroach errors.Errorf for one-off errors #1145

merged 2 commits into from
Jan 24, 2025

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Jan 23, 2025

This PR changes all uses of fmt.Errorf() to use the equivalent cockroach library instead. This gives us stack traces for all errors constructed this way during testing and debugging.

@zachmu zachmu requested a review from Hydrocharged January 23, 2025 20:48
Copy link
Contributor

Main PR
covering_index_scan_postgres 373.01/s 360.50/s -3.4%
index_join_postgres 153.03/s 151.79/s -0.9%
index_join_scan_postgres 184.28/s 182.12/s -1.2%
index_scan_postgres 12.49/s 12.45/s -0.4%
oltp_point_select 2874.39/s 2785.18/s -3.2%
oltp_read_only 1909.58/s 1859.68/s -2.7%
select_random_points 112.61/s 111.24/s -1.3%
select_random_ranges 129.65/s 127.88/s -1.4%
table_scan_postgres 11.87/s 11.83/s -0.4%
types_table_scan_postgres 5.66/s 5.61/s -0.9%

Copy link
Contributor

Main PR
Total 42090 42090
Successful 15531 15531
Failures 26559 26559
Partial Successes1 5224 5224
Main PR
Successful 36.8995% 36.8995%
Failures 63.1005% 63.1005%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@zachmu zachmu enabled auto-merge January 23, 2025 22:16
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmu zachmu merged commit 3ad20a9 into main Jan 24, 2025
18 checks passed
@zachmu zachmu deleted the zachmu/error3 branch January 24, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants