Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to get an exact permutation from parser tests #61

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

Hydrocharged
Copy link
Collaborator

This allows you to pass in a number and get that exact permutation. So that means that, even though SELECT has 144 septillion permutations, if we give it 25,757,684,286,468,754, then it will give us exactly that permutation. So to generate a set of tests, we just generate some amount of random numbers between [0, permutations), and we have our tests!

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach of spreading out to cover a tractable number of test cases across the entire space of all permutations.

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hydrocharged Hydrocharged merged commit 7baab9e into main Dec 2, 2023
6 checks passed
@Hydrocharged Hydrocharged deleted the daylon/command-random-tests branch December 2, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants