Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage metrics to doltgres #65

Merged
merged 24 commits into from
Dec 14, 2023
Merged

Add usage metrics to doltgres #65

merged 24 commits into from
Dec 14, 2023

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Dec 8, 2023

Usage metrics are now reported to the dolthub metrics servers for the sql-server command, tagged with the doltgres application ID.

Also refactors application and server start to put top-level concerns in the main method.

@zachmu zachmu marked this pull request as ready for review December 14, 2023 01:50
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure why the bats tests are broken, but it looks good from what I can tell

main.go Outdated Show resolved Hide resolved
@zachmu
Copy link
Member Author

zachmu commented Dec 14, 2023

LGTM! Not sure why the bats tests are broken, but it looks good from what I can tell

It was because I removed the init command on accident. Works now.

@zachmu zachmu changed the title Zachmu/server start Add usage metrics to doltgres Dec 14, 2023
@zachmu zachmu merged commit aa3f8c9 into main Dec 14, 2023
6 checks passed
@zachmu zachmu deleted the zachmu/server-start branch December 14, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants