Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End to end tests of all postgres types (many skipped) #77

Merged
merged 3 commits into from
Dec 19, 2023
Merged

End to end tests of all postgres types (many skipped) #77

merged 3 commits into from
Dec 19, 2023

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Dec 19, 2023

Behavior and syntax verified against postgres, but many of them may require custom types instead of strings when implemented.

@zachmu zachmu requested a review from Hydrocharged December 19, 2023 02:30
Hydrocharged
Hydrocharged approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

testing/go/types_test.go Show resolved Hide resolved
@zachmu zachmu merged commit d264839 into main Dec 19, 2023
6 checks passed
@zachmu zachmu deleted the zachmu/types branch December 19, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmu @Hydrocharged