Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added static analyzer & linter #79

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Added static analyzer & linter #79

merged 1 commit into from
Dec 19, 2023

Conversation

Hydrocharged
Copy link
Collaborator

@Hydrocharged Hydrocharged commented Dec 19, 2023 •
edited
Loading

This adds a static analyzer and linter. This is just to help enforce a bit more code quality.

@Hydrocharged Hydrocharged requested a review from zachmu December 19, 2023 12:59
@Hydrocharged
Copy link
Collaborator Author

Everything that has been changed were due to things that were pointed out. Some changes are due to changed functionality, such as removing seedGlobalRand since Go 1.20 made the call redundant. If you have any questions on any of the changes, then definitely ask! It usually gives a reason (or valid alternatives) to why some things need to be changed, and of course you don't get that context while reviewing.

zachmu
zachmu approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

main.go Show resolved Hide resolved
@Hydrocharged Hydrocharged merged commit 77acc5c into main Dec 19, 2023
7 checks passed
@Hydrocharged Hydrocharged deleted the daylon/staticcheck branch December 19, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hydrocharged @zachmu