Fix panic when a RANGE window frame offset pushes a SET/ENUM order-by value outside its valid domain - #3670
Open
fulghum wants to merge 2 commits into
Open
Fix panic when a RANGE window frame offset pushes a SET/ENUM order-by value outside its valid domain#3670fulghum wants to merge 2 commits into
fulghum wants to merge 2 commits into
Conversation
angelamayxie
reviewed
Aug 6, 2026
angelamayxie
reviewed
Aug 6, 2026
angelamayxie
left a comment
angelamayxie
left a comment
Contributor
There was a problem hiding this comment.
Left a comment. Could you also remove the LLM slop comments, or at least make them more concise?
… value outside its valid domain, and stop swallowing non-EOF framer errors that let it turn into an out-of-bounds index.
fulghum
force-pushed
the
fulghum/window-bugfix
branch
from
August 6, 2026 23:59
ad55299 to
e20fca3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also stops swallowing non-EOF framer errors that let it turn into an out-of-bounds index.
Fixes: dolthub/dolt#11397