Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36 #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #36 #37

wants to merge 1 commit into from

Conversation

paladox
Copy link

@paladox paladox commented Oct 2, 2015

No description provided.

@paladox
Copy link
Author

paladox commented Oct 2, 2015

@hartman do I have permission to upload this patch.

@RomanEmelyanov
Copy link

@paladox
Hi!
I'm can not confirm that your patch works with 5.0 -> http://us2.ytapi.com/dev/50.php
Please, check.

@paladox
Copy link
Author

paladox commented Oct 8, 2015

Hi the patch is mainly for working with the timedmediahandler extension but I can have a look.

@paladox
Copy link
Author

paladox commented Oct 8, 2015

We also had the problem your seeing it seems it isent creating the data-res tag for the resolution our workaround was to use data-shorttitle since data-res wasent being created or wasent correctly finding the resolutions for those videos and displaying them in the list.

@@ -381,7 +385,9 @@
});

// Add the button to the control bar object and the DOM
player.controlBar.resolutionSelector = player.controlBar.addChild( resolutionSelector );
this.on( 'ready' , function() {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it could be this part. causing the problem for you.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update http://us2.ytapi.com/dev/50.php with patch above, but not worked :(

@paladox
Copy link
Author

paladox commented Oct 8, 2015

It shows these errors

SCRIPT438: Object doesn't support property or method 'extends'

VIDEOJS: ERROR: Unable to find plugin: resolutionSelector

in the f12 developer tool in internet explorer.

@RomanEmelyanov
Copy link

Google Chrome errors in console:
Uncaught TypeError: V.extends is not a function
VIDEOJS: ERROR: Unable to find plugin: resolutionSelector

@RomanEmelyanov
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants