-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36 #37
base: master
Are you sure you want to change the base?
Fixes #36 #37
Conversation
@hartman do I have permission to upload this patch. |
@paladox |
Hi the patch is mainly for working with the timedmediahandler extension but I can have a look. |
We also had the problem your seeing it seems it isent creating the data-res tag for the resolution our workaround was to use data-shorttitle since data-res wasent being created or wasent correctly finding the resolutions for those videos and displaying them in the list. |
@@ -381,7 +385,9 @@ | |||
}); | |||
|
|||
// Add the button to the control bar object and the DOM | |||
player.controlBar.resolutionSelector = player.controlBar.addChild( resolutionSelector ); | |||
this.on( 'ready' , function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it could be this part. causing the problem for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update http://us2.ytapi.com/dev/50.php with patch above, but not worked :(
It shows these errors SCRIPT438: Object doesn't support property or method 'extends' VIDEOJS: ERROR: Unable to find plugin: resolutionSelector in the f12 developer tool in internet explorer. |
Google Chrome errors in console: |
For 5.0 use https://github.com/kmoskwiak/videojs-resolution-switcher instead |
No description provided.