Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warning for "unexpected input predicate-quantifier" #258

Closed
wants to merge 1 commit into from

Conversation

dswaffordcw
Copy link

Overview

This PR addresses the GitHub warning:

Unexpected input(s) 'predicate-quantifier', valid inputs are ['token', 'working-directory', 'ref', 'base', 'filters', 'list-files', 'initial-fetch-depth']

Which appears in any GitHub action run using dorny/paths-filter@v3 with predicate-quantifier configured.

Description

At first, I thought my team's use of dorny/paths-filter was configured wrong. I thought I needed to remove our use of predicate-quantifier but then saw this GitHub issue. That linked to the original PR where this was added.

I am not familiar with GitHub action development, but upon browsing action.yaml, I see all of the other possible inputs defined. That did not have predicate-quantifier, so I believe this fix is as simple as defining it there. This PR adds that, with a description based on the comments added by the original author.

Testing

I am unsure of how to test this change. Please advise and/or help with that aspect.

@dswaffordcw
Copy link
Author

cc @petermetz

@petermetz
Copy link
Contributor

@dswaffordcw Thank you for submitting the PR! Unfortunately pull requests haven't been merged here for a while and so the same fix I submitted here #226 has gone unmerged as well. Hopefully the author will have some time in the near future to merge either one of our PRs and then it will get fixed. In the meantime the only options are a friendly/temporary fork or just downgrading and not using the predicate quantifier.

@dswaffordcw dswaffordcw force-pushed the fix/predicate-warning branch from 408499a to 4c1c3ac Compare February 1, 2025 02:12
@dswaffordcw
Copy link
Author

@dswaffordcw Thank you for submitting the PR! Unfortunately pull requests haven't been merged here for a while and so the same fix I submitted here #226 has gone unmerged as well. Hopefully the author will have some time in the near future to merge either one of our PRs and then it will get fixed. In the meantime the only options are a friendly/temporary fork or just downgrading and not using the predicate quantifier.

Ah! That's lame. I didn't realize that it was dropped on the maintainer's side.

@dswaffordcw
Copy link
Author

Closing as this is a duplicate of #226

@dswaffordcw dswaffordcw closed this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants